alamb commented on code in PR #7322:
URL: https://github.com/apache/arrow-rs/pull/7322#discussion_r2010558897


##########
arrow-array/src/cast.rs:
##########
@@ -72,7 +72,7 @@ macro_rules! repeat_pat {
 /// [`DataType`]: arrow_schema::DataType
 #[macro_export]
 macro_rules! downcast_integer {
-    ($($data_type:expr),+ => ($m:path $(, $args:tt)*), $($p:pat => 
$fallback:expr $(,)*)*) => {
+    ($($data_type:expr),+ => ($m:path $(, $args:tt)*), $($p:pat $(if 
$pred:expr)* => $fallback:expr $(,)*)*) => {

Review Comment:
   Thanks @rluvaton  -- this looks useful
   
   In order for others to be able to find and use this functionality, can you 
please add some doc examples that show how to use this optional `if_predicate` 
syntax?
   
   This applies to all macros to which you added the option



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to