raulcd commented on code in PR #45849:
URL: https://github.com/apache/arrow/pull/45849#discussion_r2011913102
##########
python/pyarrow/tests/test_pandas.py:
##########
@@ -4891,20 +4886,6 @@ def make_df_with_timestamps():
return df
[email protected]
[email protected]("ignore:Parquet format '2.0':FutureWarning")
-def test_timestamp_as_object_parquet(tempdir):
- # Timestamps can be stored as Parquet and reloaded into Pandas with no loss
- # of information if the timestamp_as_object option is True.
- df = make_df_with_timestamps()
- table = pa.Table.from_pandas(df)
- filename = tempdir / "timestamps_from_pandas.parquet"
- pq.write_table(table, filename, version="2.0")
Review Comment:
same question as above, doesn't this work with parquet 2.6? What is the
problem?
##########
python/pyarrow/tests/parquet/test_pandas.py:
##########
@@ -269,18 +268,6 @@ def test_pandas_parquet_configuration_options(tempdir):
tm.assert_frame_equal(df, df_read)
[email protected]
[email protected]("ignore:Parquet format '2.0':FutureWarning")
-def test_spark_flavor_preserves_pandas_metadata():
- df = _test_dataframe(size=100)
- df.index = np.arange(0, 10 * len(df), 10)
- df.index.name = 'foo'
-
- result = _roundtrip_pandas_dataframe(df, {'version': '2.0',
- 'flavor': 'spark'})
Review Comment:
what happens on this test if we use a different parquet version?
I am wondering if this should still pass for `2.6`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
