pitrou commented on code in PR #45459:
URL: https://github.com/apache/arrow/pull/45459#discussion_r2016141637
##########
cpp/src/parquet/metadata.cc:
##########
@@ -111,6 +112,16 @@ static std::shared_ptr<Statistics> MakeTypedColumnStats(
metadata.statistics.__isset.null_count,
metadata.statistics.__isset.distinct_count);
}
+static std::shared_ptr<GeoStatistics> MakeColumnGeometryStats(
+ const format::ColumnMetaData& metadata, const ColumnDescriptor* descr) {
+ if (metadata.__isset.geospatial_statistics) {
+ EncodedGeoStatistics encoded_geo_stats =
FromThrift(metadata.geospatial_statistics);
+ return std::make_shared<GeoStatistics>(encoded_geo_stats);
Review Comment:
```suggestion
return std::make_shared<GeoStatistics>(std::move(encoded_geo_stats));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
