mbrobbel commented on code in PR #7126: URL: https://github.com/apache/arrow-rs/pull/7126#discussion_r2010770347
########## arrow-array/src/run_iterator.rs: ########## @@ -209,7 +209,7 @@ mod tests { seed.shuffle(&mut rng); } // repeat the items between 1 and 8 times. Cap the length for smaller sized arrays - let num = max_run_length.min(rand::thread_rng().gen_range(1..=max_run_length)); + let num = max_run_length.min(rand::rng().random_range(1..=max_run_length)); Review Comment: Same here: ```suggestion let num = max_run_length.min(rng.random_range(1..=max_run_length)); ``` ########## arrow-array/src/array/run_array.rs: ########## @@ -700,7 +700,7 @@ mod tests { seed.shuffle(&mut rng); } // repeat the items between 1 and 8 times. Cap the length for smaller sized arrays - let num = max_run_length.min(rand::thread_rng().gen_range(1..=max_run_length)); + let num = max_run_length.min(rand::rng().random_range(1..=max_run_length)); Review Comment: I think we can re-use the `rng` generator here: ```suggestion let num = max_run_length.min(rng.random_range(1..=max_run_length)); ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org