Dandandan commented on a change in pull request #9860:
URL: https://github.com/apache/arrow/pull/9860#discussion_r604810284
##########
File path: rust/arrow/src/array/builder.rs
##########
@@ -2031,6 +2059,7 @@ where
/// Append a primitive value to the array. Return an existing index
/// if already present in the values array or a new index if the
/// value is appended to the values array.
+ #[inline]
Review comment:
This seems a large function to inline? Maybe we need to be conservative
here and not mark it as inline
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
