WillAyd commented on code in PR #45858:
URL: https://github.com/apache/arrow/pull/45858#discussion_r2021057784


##########
ci/scripts/cpp_build.sh:
##########
@@ -118,12 +118,36 @@ if [ "${ARROW_USE_MESON:-OFF}" = "ON" ]; then
     fi
   }
 
+  ORIGINAL_CC="${CC}"
+  if [ -n "${CC}" ]; then
+    if [ "${ARROW_USE_CCACHE}" = "ON" ]; then
+      CC="ccache ${CC}"
+    else
+      if command -v sccache; then
+        CC="sccache ${CC}"
+      fi
+    fi
+  fi
+
+  ORIGINAL_CXX="${CXX}"
+  if [ -n "${CXX}" ]; then
+    if [ "${ARROW_USE_CCACHE}" = "ON" ]; then
+      CXX="ccache ${CXX}"
+    else
+      if command -v sccache; then
+        CXX="sccache ${CXX}"
+      fi
+    fi
+  fi
   meson setup \

Review Comment:
   My knowledge of bash syntax is pretty limited, but I did start with an 
export and was asked to remove in 
https://github.com/apache/arrow/pull/45858#discussion_r2002481071



##########
dev/tasks/tasks.yml:
##########
@@ -815,7 +815,10 @@ tasks:
     ci: github
     template: docker-tests/github.linux.yml
     params:
-      flags: -e ARROW_USE_MESON=ON
+      # ARROWCCACHE=OFF is for using sccache
+      flags: >-
+        -e ARROW_CCACHE=OFF

Review Comment:
   Thanks!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to