pitrou commented on code in PR #45854:
URL: https://github.com/apache/arrow/pull/45854#discussion_r2021340400


##########
ci/scripts/python_build.sh:
##########
@@ -89,7 +136,37 @@ pushd ${python_build_dir}
 #   on Debian/Ubuntu (ARROW-15243).
 # - Cannot use build isolation as we want to use specific dependency versions
 #   (e.g. Numpy, Pandas) on some CI jobs.
-${PYTHON:-python} -m pip install --no-deps --no-build-isolation -vv .
+
+# The conda compilers package may mess with C{XX}_FLAGS in a way that 
interferes
+# with the compiler

Review Comment:
   Well, using CMake two things would happen:
   1. the CMake build type (Debug/Release/RelWithDebInfo) automatically enables 
appropriate optimization and debug flags
   2. additionally, we have [our 
own](https://github.com/apache/arrow/blob/main/cpp/cmake_modules/SetupCxxFlags.cmake)
 flags definitions for warnings, optimizations and whatnot
   
   If the Meson setup doesn't reproduce this, then it's a problem.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to