raulcd commented on code in PR #45997:
URL: https://github.com/apache/arrow/pull/45997#discussion_r2022642323
##########
cpp/cmake_modules/ThirdpartyToolchain.cmake:
##########
@@ -957,7 +957,8 @@ set(EP_COMMON_CMAKE_ARGS
-DCMAKE_FIND_PACKAGE_NO_PACKAGE_REGISTRY=${CMAKE_FIND_PACKAGE_NO_PACKAGE_REGISTRY}
-DCMAKE_INSTALL_LIBDIR=lib
-DCMAKE_OSX_SYSROOT=${CMAKE_OSX_SYSROOT}
- -DCMAKE_VERBOSE_MAKEFILE=${CMAKE_VERBOSE_MAKEFILE})
+ -DCMAKE_VERBOSE_MAKEFILE=${CMAKE_VERBOSE_MAKEFILE}
+ -DCMAKE_POLICY_VERSION_MINIMUM=3.5)
Review Comment:
My only concern of adding this globally instead of adding this specifically
as CMake args for the individual dependencies that have issues is that we might
forget this flag (which should be temporary).
Should we add at least a note saying: `# Remove once all dependencies for
https://github.com/apache/arrow/issues/45985 have been updated` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
