eli-schwartz commented on code in PR #45854:
URL: https://github.com/apache/arrow/pull/45854#discussion_r2023055525
##########
ci/scripts/python_build.sh:
##########
@@ -89,7 +136,37 @@ pushd ${python_build_dir}
# on Debian/Ubuntu (ARROW-15243).
# - Cannot use build isolation as we want to use specific dependency versions
# (e.g. Numpy, Pandas) on some CI jobs.
-${PYTHON:-python} -m pip install --no-deps --no-build-isolation -vv .
+
+# The conda compilers package may mess with C{XX}_FLAGS in a way that
interferes
+# with the compiler
Review Comment:
Meson supports using buildtypes to define default optimization/debug flags,
yes.
It's pretty standard for flags specified in $CFLAGS to be considered "user
flags which should take priority over project default flags", so, exporting
those environment variables and having them contain flags you don't actually
want to be added to your build seems generally risky.
It does depend on whether project default flags are handled via the
buildtype (user flags override it) or via "mandatory project options" such as
`add_project_arguments('-DHAVE_CONFIG_H', language: 'cpp')`.
It's possible to set buildtype options multiple times by lumping it in with
mandatory options, but it's not very clean as it is a layering purity violation
and will probably annoy people that do things like build a couple hundred
packages with `export CFLAGS="-O0 -ggdb"` to debug an environment and don't
want to chase down individual per-project options for all hundred packages.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
