thisisnic commented on PR #45818: URL: https://github.com/apache/arrow/pull/45818#issuecomment-2768606465
Hey @AlenkaF , I think this is ready for another look! I've implemented the simple ones, and some of the more complex ones already exist. I was unsure about how to approach "binary scalars implement perhaps the buffer protocol". I was also unsure how to approach the code examples with min_max: ``` >>> a, b = pc.min_max([1,2,3]) >>> a # expecting 1 'min' >>> b # expecting 3 'max' ``` This happens as it returns a StructScalar, which I'm assuming is analagous to a dictionary, and this behaviour feels like expected behaviour from that perspective? I did try to see if I could implement `values()`, `keys()` and `items()`, but other tests broke, and I couldn't find a way of changing this without introducing a breaking change here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
