pitrou commented on code in PR #41765:
URL: https://github.com/apache/arrow/pull/41765#discussion_r2023214655
##########
cpp/src/parquet/arrow/arrow_schema_test.cc:
##########
@@ -1636,6 +1659,22 @@ TEST(TestFromParquetSchema, CorruptMetadata) {
ASSERT_RAISES(IOError, FromParquetSchema(parquet_schema, props,
&arrow_schema));
}
+TEST(TestFromParquetSchema, UndefinedLogicalType) {
+ // Arrow GH-45522
+ auto path = test::get_data_file("unknown-logical-type.parquet");
+
+ std::unique_ptr<parquet::ParquetFileReader> reader =
+ parquet::ParquetFileReader::OpenFile(path);
+ const auto parquet_schema = reader->metadata()->schema();
+ std::shared_ptr<::arrow::Schema> arrow_schema;
+
+ // With the appropriate reader option set, the underlying physical type is
used for
+ // conversion to the Arrow type
Review Comment:
There is no reader option, should this comment be removed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
