kou commented on code in PR #45854:
URL: https://github.com/apache/arrow/pull/45854#discussion_r2024001410
##########
dev/release/02-source-test.rb:
##########
@@ -84,7 +84,12 @@ def test_csharp_git_commit_information
def test_python_version
source
Dir.chdir("#{@tag_name_no_rc}/python") do
- sh("python3", "setup.py", "sdist")
+ # Meson dist must be run from a VCS, so initiate a dummy repo
+ sh("git", "init", ".")
+ sh("git", "add", "--all", ".")
+ sh("git", "commit", "-m", "dummy commit for meson dist")
+ sh("python3", "-m", "pip", "install", "build")
+ sh("python3", "-m", "build", "--sdist", ".")
Review Comment:
Can we update
https://github.com/apache/arrow/blob/main/ci/scripts/python_sdist_build.sh and
use it here?
Our release process uses it:
https://github.com/apache/arrow/blob/main/dev/tasks/python-sdist/github.yml
Hmm... It doesn't use the source archive... We may not need this test...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
