CurtHagenlocher commented on code in PR #2667: URL: https://github.com/apache/arrow-adbc/pull/2667#discussion_r2025718597
########## csharp/src/Drivers/Apache/Spark/README.md: ########## @@ -40,7 +40,7 @@ but can also be passed in the call to `AdbcDatabase.Connect`. | `adbc.apache.statement.batch_size` | Sets the maximum number of rows to retrieve in a single batch request. | `50000` | | `adbc.apache.statement.polltime_ms` | If polling is necessary to get a result, this option sets the length of time (in milliseconds) to wait between polls. | `500` | | `adbc.apache.statement.query_timeout_s` | Sets the maximum time (in seconds) for a query to complete. Values can be 0 (infinite) or greater than zero. | `60` | -| `adbc.http_options.tls.enabled` | If tls needs to enabled or not. One of `True`, `False` | `False` | +| `adbc.http_options.tls.enabled` | If tls needs to enabled or not. One of `True`, `False` | `True` for `adbc.spark.type` with value `databricks`, `False`, otherwise. | Review Comment: I would argue that the real problem with the previous change is that in 2025 no one should disable TLS by default. We should instead default this to `True` (except, perhaps, when using port 80) and force people into the insecure setting. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
