projjal commented on a change in pull request #9813:
URL: https://github.com/apache/arrow/pull/9813#discussion_r605107516
##########
File path: cpp/src/gandiva/filter.h
##########
@@ -45,6 +45,10 @@ class FilterCacheKey {
bool operator!=(const FilterCacheKey& other) const { return !(*this ==
other); }
+ bool operator<(const FilterCacheKey& other) const {
+ return uniqifier_ < other.uniqifier_;
Review comment:
This is not correct I believe. Also why is this needed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
