pitrou commented on code in PR #45360:
URL: https://github.com/apache/arrow/pull/45360#discussion_r2026590866


##########
cpp/src/parquet/properties.h:
##########
@@ -245,6 +245,14 @@ class PARQUET_EXPORT ColumnProperties {
   bool page_index_enabled_;
 };
 
+struct CDCOptions {
+  int64_t min_chunk_size;
+  int64_t max_chunk_size;
+  int8_t norm_factor;
+};
+
+static constexpr CDCOptions kDefaultCdcOptions = CDCOptions{256 * 1024, 1024 * 
1024, 0};

Review Comment:
   > Regarding the data page size, the default is
   > 
   > ```c++
   > static constexpr int64_t kDefaultDataPageSize = 1024 * 1024;
   > ```
   
   Hmm, I'm getting confused about the [desired data page 
size](https://lists.apache.org/thread/vsxmbvnx9gy5414cfo25mnwcj17h1xyp) again. 
@wgtmac Can you enlighten me/us here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to