tustvold opened a new issue, #242:
URL: https://github.com/apache/arrow-rs-object-store/issues/242

   **Is your feature request related to a problem or challenge? Please describe 
what you are trying to do.**
   <!--
   A clear and concise description of what the problem is. Ex. I'm always 
frustrated when [...] 
   (This section helps Arrow developers understand the context and *why* for 
this feature, in addition to  the *what*)
   -->
   
   There are 4 broadly supported request preconditions:
   
   * If-Match
   * If-None-Match
   * If-Modified-Since
   * If-Unmodified-Since
   
   https://cloud.google.com/storage/docs/request-preconditions
   
https://docs.microsoft.com/en-us/rest/api/storageservices/specifying-conditional-headers-for-blob-service-operations
   
https://docs.aws.amazon.com/AmazonS3/latest/API/API_GetObject.html#API_GetObject_RequestSyntax
   
   **Describe the solution you'd like**
   <!--
   A clear and concise description of what you want to happen.
   -->
   
   I would like to propose adding
   
   
   ```
   #[derive(Debug, Default)]
   struct GetOptions {
       pub if_match: Option<String>,
       pub if_none_match: Option<String>,
       pub if_modified_since: Option<DateTime<Utc>>,
       pub if_unmodified_since: Option<DateTime<Utc>>,
       pub range: Option<usize>
   }
   
   pub trait ObjectStore {
        async fn get_opts(&self, location: &Path, options: GetOptions) -> 
Result<GetResult>
        ...
   }
   
   pub enum Error {
       #[snafu(display("Precondition failed: {}", source))]
       Precondition {
           source: Box<dyn std::error::Error + Send + Sync + 'static>,
       }
   
       #[snafu(display("Not modified: {}", source))]
       NotModified {
           source: Box<dyn std::error::Error + Send + Sync + 'static>,
       }
   }
   ```
   
   **Describe alternatives you've considered**
   <!--
   A clear and concise description of any alternative solutions or features 
you've considered.
   -->
   
   We could not add support for this
   
   **Additional context**
   <!--
   Add any other context or screenshots about the feature request here.
   -->
   
   apache/arrow-rs#2230 
   apache/arrow-rs#2240 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to