alamb commented on PR #7375: URL: https://github.com/apache/arrow-rs/pull/7375#issuecomment-2775358812
> @alamb Before making the change, could you please help to check something below, thanks. > > 1. The tests in `arrow/src/util/test_util.rs` will show that it uses deprecated code when doing clippy, do I need to add `#[allow(deprecated)]` before the function `pub fn seedable_rng() `(after removing all the outside usage) > 2. When removing the usage of the function in `arrow/src/util/test_util.rs`(`seedable_rng`, `parquet_test_data`, and `arrow_test_data`), we can copy the code from `arrow/src/util/test_util.rs` to the other place, is this understanding right? if not, what else do I need to do > 3. After removing the outside usage, do we need to remove the dead function for now, or we can do it in a follow pr. I recommend doing the `[allow(deprecated)]` route -- and when we are ready to actually remove the deprecated API (per guideliens here https://github.com/apache/arrow-rs?tab=readme-ov-file#rust-version-compatibility-policy) then we can copy / move the code elsewhre -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
