alamb commented on PR #7354:
URL: https://github.com/apache/arrow-rs/pull/7354#issuecomment-2762459380

   My benchmark results show no significant change in performance
   
   ```
   ++ critcmp main write-page-encoding-stats
   group                                                                     
main                                   write-page-encoding-stats
   -----                                                                     
----                                   -------------------------
   write_batch nested/4096 values primitive list                             
1.02      7.0±0.24ms   304.9 MB/sec    1.00      6.8±0.27ms   312.2 MB/sec
   write_batch nested/4096 values primitive list non-null                    
1.03      8.4±0.33ms   253.8 MB/sec    1.00      8.2±0.29ms   260.3 MB/sec
   write_batch primitive/4096 values bool                                    
1.01  1022.3±42.00µs  1062.3 KB/sec    1.00  1014.0±33.50µs  1070.9 KB/sec
   write_batch primitive/4096 values bool non-null                           
1.00   944.9±25.45µs   620.1 KB/sec    1.00   940.3±32.14µs   623.2 KB/sec
   write_batch primitive/4096 values float with NaNs                         
1.01  1841.7±48.57µs    29.8 MB/sec    1.00  1831.0±68.81µs    30.0 MB/sec
   write_batch primitive/4096 values primitive                               
1.02      2.9±0.13ms    60.0 MB/sec    1.00      2.9±0.10ms    61.2 MB/sec
   write_batch primitive/4096 values primitive non-null                      
1.00      2.8±0.54ms    61.7 MB/sec    1.01      2.8±0.71ms    60.8 MB/sec
   write_batch primitive/4096 values primitive non-null with bloom filter    
1.00     21.6±0.69ms     8.0 MB/sec    1.00     21.5±0.36ms     8.0 MB/sec
   write_batch primitive/4096 values primitive with bloom filter             
1.00     21.3±0.31ms     8.2 MB/sec    1.01     21.5±1.25ms     8.2 MB/sec
   write_batch primitive/4096 values string                                  
1.00  1734.3±48.79µs    72.8 MB/sec    1.00  1742.8±59.87µs    72.4 MB/sec
   write_batch primitive/4096 values string dictionary                       
1.00      4.1±0.16ms   253.3 MB/sec    1.02      4.1±0.19ms   249.2 MB/sec
   write_batch primitive/4096 values string dictionary with bloom filter     
1.02      6.0±0.37ms   172.2 MB/sec    1.00      5.9±0.40ms   174.8 MB/sec
   write_batch primitive/4096 values string non-null                         
1.00      7.3±0.36ms   281.0 MB/sec    1.00      7.3±0.44ms   281.0 MB/sec
   write_batch primitive/4096 values string non-null with bloom filter       
1.05     11.4±0.41ms   180.2 MB/sec    1.00     10.9±0.44ms   188.4 MB/sec
   write_batch primitive/4096 values string with bloom filter                
1.02     11.5±0.47ms   177.5 MB/sec    1.00     11.3±0.44ms   181.7 MB/sec
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to