lidavidm commented on code in PR #2609:
URL: https://github.com/apache/arrow-adbc/pull/2609#discussion_r2006871434
##########
python/adbc_driver_manager/adbc_driver_manager/dbapi.py:
##########
@@ -642,17 +663,12 @@ def _bind(self, parameters) -> None:
self._stmt.bind(parameters)
elif hasattr(parameters, "__arrow_c_stream__"):
self._stmt.bind_stream(parameters)
- elif isinstance(parameters, pyarrow.RecordBatch):
- arr_handle = _lib.ArrowArrayHandle()
- sch_handle = _lib.ArrowSchemaHandle()
- parameters._export_to_c(arr_handle.address, sch_handle.address)
- self._stmt.bind(arr_handle, sch_handle)
+ elif _lib.is_pycapsule(parameters, b"arrow_array"):
+ self._stmt.bind(parameters)
Review Comment:
Ah, right. The `__arrow_c_array__` returns both, but obviously once you have
a PyCapsule it makes no sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
