Turbo87 opened a new issue, #156:
URL: https://github.com/apache/arrow-rs-object-store/issues/156

   **Is your feature request related to a problem or challenge? Please describe 
what you are trying to do.**
   <!--
   A clear and concise description of what the problem is. Ex. I'm always 
frustrated when [...] 
   (This section helps Arrow developers understand the context and *why* for 
this feature, in addition to  the *what*)
   -->
   
   Some parts of our test suite are not (yet) using async everywhere and we 
have a need to `clone()` the `InMemory` object store to use it in several parts 
of the application. The fact that `clone()` is currently async makes this 
unnecessarily hard, especially since nothing within the `clone()` fn is 
actually async code anymore.
   
   **Describe the solution you'd like**
   <!--
   A clear and concise description of what you want to happen.
   -->
   
   I propose to remove the `async` keyword from the `clone()` fn, and then to 
implement the `Clone` trait since afterwards the function signature should 
match the one from the trait.
   
   **Describe alternatives you've considered**
   <!--
   A clear and concise description of any alternative solutions or features 
you've considered.
   -->
   
   The only alternative is keeping the obsolete async keyword on the function. 
   
   **Additional context**
   <!--
   Add any other context or screenshots about the feature request here.
   -->
   
   The `async` keyword was there in the [very first 
commit](https://github.com/influxdata/object_store_rs/commit/56483a119cacbe9814a88b0a4e127b2c95a405de)
 to the project because at that point an async `RwLock` from tokio was used 
instead of the `parking_lot` variant which no longer requires the `async` 
keyword.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to