EnricoMi commented on code in PR #46017:
URL: https://github.com/apache/arrow/pull/46017#discussion_r2031169102
##########
cpp/src/parquet/encryption/key_toolkit.h:
##########
@@ -92,14 +92,14 @@ class PARQUET_EXPORT KeyToolkit {
// parsing from "key material"
class PARQUET_EXPORT KeyWithMasterId {
public:
- KeyWithMasterId(std::string key_bytes, std::string master_id)
+ KeyWithMasterId(SecureString key_bytes, std::string master_id)
: key_bytes_(std::move(key_bytes)), master_id_(std::move(master_id)) {}
- const std::string& data_key() const { return key_bytes_; }
+ const SecureString& data_key() const { return key_bytes_; }
const std::string& master_id() const { return master_id_; }
private:
- const std::string key_bytes_;
+ const SecureString key_bytes_;
const std::string master_id_;
Review Comment:
Removed, also added `[[nodiscard]]` to the constant getter methods.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
