birschick-bq commented on code in PR #2695:
URL: https://github.com/apache/arrow-adbc/pull/2695#discussion_r2038211467
##########
csharp/src/Drivers/Apache/Hive2/HiveServer2Statement.cs:
##########
@@ -426,12 +427,128 @@ private async Task<QueryResult>
GetQueryResult(TSparkDirectResults? directResult
int columnCount = HiveServer2Reader.GetColumnCount(rowSet);
int rowCount = HiveServer2Reader.GetRowCount(rowSet,
columnCount);
IReadOnlyList<IArrowArray> data =
HiveServer2Reader.GetArrowArrayData(rowSet, columnCount, schema,
Connection.DataTypeConversion);
+
+ // Enhance column schema results if this is a GetColumns query
+ if (SqlQuery?.ToLowerInvariant() == GetColumnsCommandName)
Review Comment:
I think you can refactor this method so that you don't need to test if the
current query is the `GetColumnsCommandName`. The `EnhanceGetColumnsResult`
should be called from within `GetColumnsAsync`.
I can propose a refactor that uses virtual implementations, if you want a
more concrete suggestion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
