mapleFU commented on code in PR #45535:
URL: https://github.com/apache/arrow/pull/45535#discussion_r2040179366
##########
cpp/src/arrow/testing/gtest_util.cc:
##########
@@ -478,17 +478,24 @@ Result<std::shared_ptr<Table>> RunEndEncodeTableColumns(
const int num_columns = table.num_columns();
std::vector<std::shared_ptr<ChunkedArray>> encoded_columns;
encoded_columns.reserve(num_columns);
+ std::vector<std::shared_ptr<Field>> encoded_fields;
+ encoded_fields.reserve(num_columns);
for (int i = 0; i < num_columns; i++) {
+ auto field = table.schema()->field(i);
if (std::find(column_indices.begin(), column_indices.end(), i) !=
column_indices.end()) {
ARROW_ASSIGN_OR_RAISE(auto run_end_encoded,
compute::RunEndEncode(table.column(i)));
DCHECK_EQ(run_end_encoded.kind(), Datum::CHUNKED_ARRAY);
encoded_columns.push_back(run_end_encoded.chunked_array());
+ auto encoded_type = arrow::run_end_encoded(arrow::int32(),
field->type());
+ encoded_fields.push_back(field->WithType(encoded_type));
} else {
encoded_columns.push_back(table.column(i));
+ encoded_fields.push_back(field);
}
}
- return Table::Make(table.schema(), std::move(encoded_columns));
+ auto updated_schema = arrow::schema(encoded_fields);
Review Comment:
```suggestion
auto updated_schema = arrow::schema(std::move(encoded_fields));
```
##########
cpp/src/arrow/testing/gtest_util.cc:
##########
@@ -478,17 +478,24 @@ Result<std::shared_ptr<Table>> RunEndEncodeTableColumns(
const int num_columns = table.num_columns();
std::vector<std::shared_ptr<ChunkedArray>> encoded_columns;
encoded_columns.reserve(num_columns);
+ std::vector<std::shared_ptr<Field>> encoded_fields;
+ encoded_fields.reserve(num_columns);
for (int i = 0; i < num_columns; i++) {
+ auto field = table.schema()->field(i);
Review Comment:
nit:
```suggestion
auto& field = table.schema()->field(i);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
