wjones127 commented on a change in pull request #8844:
URL: https://github.com/apache/arrow/pull/8844#discussion_r606019221
##########
File path: cpp/src/gandiva/regex_util.h
##########
@@ -29,7 +29,7 @@ namespace gandiva {
/// \brief Utility class for converting sql patterns to pcre patterns.
class GANDIVA_EXPORT RegexUtil {
public:
- // Convert an sql pattern to a pcre pattern
+ // Convert an sql pattern to a pcre pattern for use with PartialMatch
Review comment:
Previously, `like` was using `RE2::FullMatch`. However, `regexp_matches`
needs to use `RE2::PartialMatch`, so I've modified this method to make partial
match statements. I have added a new set of tests to validate it.
I didn't see any use of this utility method outside of the `like`
implementation, so I thought this change would be okay.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
