jonkeane commented on code in PR #46124:
URL: https://github.com/apache/arrow/pull/46124#discussion_r2041124572
##########
r/tests/testthat/helper-skip.R:
##########
@@ -97,6 +97,7 @@ skip_on_linux_devel <- function() {
# Skip when the OS is linux + and the R version is development
# helpful for skipping on Valgrind, and the sanitizer checks (clang + gcc)
on cran
if (on_linux_dev()) {
+ return()
skip_on_cran()
Review Comment:
This was me trying to trigger ubsan failures on linux that we were seeing on
CRAN's M1, but that didn't work (I'll back those changes out). I _have_ found a
way I believe to run the M1 checks, which I'm trying right now. Once I get a
failure there I'll push the fixes I have too (but I want to prove to myself
that our CI is catching this before pushing the proposed fixes). I'll tag you
when this is ready, as always thanks for your help 🙏
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
