amoeba commented on code in PR #46124:
URL: https://github.com/apache/arrow/pull/46124#discussion_r2044978743
##########
docker-compose.yml:
##########
@@ -1745,6 +1746,34 @@ services:
/bin/bash -c "
/arrow/ci/scripts/r_sanitize.sh /arrow"
+ r-clang-ubsan:
+ image: ${REPO}:r-rhub-clang-ubsan-devel-latest
+ build:
+ context: .
+ dockerfile: ci/docker/linux-r.dockerfile
+ cache_from:
+ - ${REPO}:r-rhub-clang-ubsan-devel-latest
+ args:
+ base: rhub/clang-ubsan
+ cmake: ${CMAKE}
+ r_dev: ${ARROW_R_DEV}
+ r_bin: R
+ tz: ${TZ}
+ r_prune_deps: ${R_PRUNE_DEPS}
+ shm_size: *shm-size
+ environment:
+ <<: *common
+ LIBARROW_DOWNLOAD: "false"
+ ARROW_SOURCE_HOME: "/arrow"
+ ARROW_R_DEV: ${ARROW_R_DEV}
+ # To test for CRAN release, delete ^^ these two env vars so we download
the Apache release
Review Comment:
Hrm, I'm worried about forgetting to do this step. Is there maybe a more
foolproof way to do what we want here?
##########
ci/scripts/r_sanitize.sh:
##########
@@ -36,34 +36,36 @@ ncores=$(${R_BIN} -s -e 'cat(parallel::detectCores())')
echo "MAKEFLAGS=-j${ncores}" >> ${rhome}/etc/Renviron.site
# build first so that any stray compiled files in r/src are ignored
-${R_BIN} CMD build .
-${R_BIN} CMD INSTALL ${INSTALL_ARGS} arrow*.tar.gz
+${R_BIN} CMD build --no-build-vignettes --no-manual .
# But unset the env var so that it doesn't cause us to run extra dev tests
unset ARROW_R_DEV
# Set the testthat output to be verbose for easier debugging
export ARROW_R_VERBOSE_TEST=TRUE
+export _R_CHECK_FORCE_SUGGESTS_=FALSE
Review Comment:
Worth putting your text here in the file as a comment for safe keeping?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
