alamb commented on code in PR #332:
URL:
https://github.com/apache/arrow-rs-object-store/pull/332#discussion_r2045452723
##########
src/aws/mod.rs:
##########
@@ -820,4 +821,54 @@ mod tests {
store.delete(location).await.unwrap();
}
}
+
+ /// Integration test that ensures I/O is done on an alternate threadpool
+ /// when using the `SpawnedReqwestConnector`.
+ #[test]
Review Comment:
I also wrote this end to end integration test to ensure that everything
worked correctly when hooked up to an ObjectStore implementation (and it does!)
##########
src/aws/mod.rs:
##########
@@ -820,4 +821,54 @@ mod tests {
store.delete(location).await.unwrap();
}
}
+
+ /// Integration test that ensures I/O is done on an alternate threadpool
+ /// when using the `SpawnedReqwestConnector`.
+ #[test]
+ fn s3_alternate_threadpool_spawned_request_connector() {
+ maybe_skip_integration!();
+ let (shutdown_tx, shutdown_rx) = tokio::sync::oneshot::channel::<()>();
+
+ // Runtime with I/O enabled
+ let io_runtime = tokio::runtime::Builder::new_current_thread()
+ .enable_all() // <-- turns on IO
Review Comment:
if you comment out this line the test fails
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
