CurtHagenlocher commented on issue #45559: URL: https://github.com/apache/arrow/issues/45559#issuecomment-2809459697
Are you @alexdegroot, are you asking about the existing PR which doesn't appear to have any performance improvements or about the proposed alternative which seems to have a ~1/3 time reduction? If the former, then how would you characterize the new version is better than the existing one? I don't think we should make a breaking change without some way to opt into it. Unfortunately, here's a case where the absolute difference is so small that even the overhead of checking a flag might defeat the optimization. At a high level, I think we need toadd a set of new APIs that take a context parameter, to effectively add a flag to that context and to switch between implementations at a much higher level. To be clear, I don't think that this one change would justify such an architectural shift but there are other aspects of Arrow (such as configurable support of extension types) that I think would be very hard to achieve without a kind of configurable registry. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
