davidhcoe commented on code in PR #2655: URL: https://github.com/apache/arrow-adbc/pull/2655#discussion_r2052898693
########## csharp/src/Drivers/BigQuery/ITokenProtectedResource.cs: ########## @@ -0,0 +1,40 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +using System; +using System.Threading.Tasks; + +namespace Apache.Arrow.Adbc.Drivers.BigQuery +{ + /// <summary> + /// Common interface for a token protected resource. + /// </summary> + public interface ITokenProtectedResource + { + /// <summary> + /// The function to call when updating the token. + /// </summary> + public Func<Task>? UpdateToken { get; set; } + + /// <summary> + /// Determines the token needs to be updated. + /// </summary> + /// <param name="ex">The exception that occurs.</param> + /// <returns>True/False indicating a refresh is needed.</returns> + public bool TokenRequiresUpdate(Exception ex); Review Comment: I moved this to be an internal only API, but I don't think it can be split into two different APIs just because RetryManager looks at the ITokenProtectedResource to determine if the token needs to be updated then invokes the delegate for the update to occur. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
