lidavidm commented on code in PR #2718:
URL: https://github.com/apache/arrow-adbc/pull/2718#discussion_r2055352618
##########
.github/workflows/nightly-verify.yml:
##########
@@ -201,3 +205,31 @@ jobs:
run: |
pushd arrow-adbc
docker compose run -e PYTHON=3.12 --rm python-debug
+
+ source-verify-docker:
+ name: "Verify Source (OS)/${{ matrix.os }} ${{ matrix.version }}"
+ runs-on: ubuntu-latest
+ strategy:
+ max-parallel: 2
+ matrix:
+ include:
+ - os: ubuntu
+ version: "22.04"
+ - os: ubuntu
+ version: "24.04"
+ steps:
+ - uses: actions/checkout@v4
+ with:
+ fetch-depth: 0
+ path: arrow-adbc
+ persist-credentials: false
+ submodules: recursive
+
+ - name: Verify
+ env:
+ OS: ${{ matrix.os }}
+ OS_VERSION: ${{ matrix.version }}
+ run: |
+ # Hmm, -e doesn't work?
Review Comment:
Example:
```
lidavidm@rondo ~/C/arrow-adbc (minor-nightly-docker)> docker compose run
--rm -e UBUNTU=22.04 -it verify-all-ubuntu /bin/bash
WARN[0000] The "UBUNTU" variable is not set. Defaulting to a blank string.
WARN[0000] /home/lidavidm/Code/arrow-adbc/compose.yaml: the attribute
`version` is obsolete, it will be ignored, please remove it to avoid potential
confusion
[+] Creating 1/1
✔ Network arrow-adbc_default Created
0.0s
unable to get image 'ubuntu:': Error response from daemon: invalid reference
format
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
