raulcd commented on code in PR #46161: URL: https://github.com/apache/arrow/pull/46161#discussion_r2055742451
########## cpp/src/arrow/compute/kernels/test_util.h: ########## @@ -0,0 +1,30 @@ +// Licensed to the Apache Software Foundation (ASF) under one Review Comment: Thanks for the detailed explanation! The only thing I am not sure I understand is: > Here we have an internal API that is used by unit tests, so needs to be exported in a DLL. What is the difference with for example: ``` Result<std::shared_ptr<Table>> MakeRandomTimeSeriesTable( const TableGenerationProperties& properties) ``` We are not using any kind of export there? And the `RunEndEncodeTableColumns` is used in a single test on `hash_aggregate_test.cc` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org