gmcrocetti commented on code in PR #46078:
URL: https://github.com/apache/arrow/pull/46078#discussion_r2058923650
##########
cpp/src/arrow/filesystem/s3fs.cc:
##########
@@ -401,6 +401,9 @@ Result<S3Options> S3Options::FromUri(const Uri& uri,
std::string* out_path) {
options.scheme = kv.second;
} else if (kv.first == "endpoint_override") {
options.endpoint_override = kv.second;
+ } else if (kv.first == "allow_delayed_open") {
Review Comment:
FYI other existing options are missing, for example: `background_writes`,
`check_directory_existence_before_creation`, `request_timeout`...
I can work on that if that's interesting for the project :)
##########
cpp/src/arrow/filesystem/s3fs.cc:
##########
@@ -401,6 +401,9 @@ Result<S3Options> S3Options::FromUri(const Uri& uri,
std::string* out_path) {
options.scheme = kv.second;
} else if (kv.first == "endpoint_override") {
options.endpoint_override = kv.second;
+ } else if (kv.first == "allow_delayed_open") {
Review Comment:
FYI other existing options are missing, for example: `background_writes`,
`check_directory_existence_before_creation`, `request_timeout`...
I can work on that if that's interesting for the project :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
