wgtmac commented on code in PR #13863:
URL: https://github.com/apache/arrow/pull/13863#discussion_r2060531101
##########
cpp/src/parquet/CMakeLists.txt:
##########
@@ -218,8 +220,9 @@ if(NOT PARQUET_MINIMAL_DEPENDENCY)
# Link publicly with parquet_static (because internal users need to
# transitively link all dependencies)
- set(PARQUET_STATIC_LINK_LIBS ${PARQUET_STATIC_LINK_LIBS} thrift::thrift)
-endif(NOT PARQUET_MINIMAL_DEPENDENCY)
+ list(APPEND PARQUET_STATIC_LINK_LIBS thrift::thrift)
+ list(APPEND PARQUET_STATIC_INTERFACE_INSTALL_LIBS thrift::thrift)
Review Comment:
@kou Why do we need this line? `thrift::thrift` is already included in the
`arrow_bundled_dependencies`. I ran into `thrift::thrift target was not found`
while linking parquet_static to iceberg_static.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
