emkornfield commented on a change in pull request #9862:
URL: https://github.com/apache/arrow/pull/9862#discussion_r606827277
##########
File path: go/arrow/internal/arrdata/ioutil.go
##########
@@ -172,6 +173,47 @@ func WriteFile(t *testing.T, f *os.File, mem
memory.Allocator, schema *arrow.Sch
}
}
+// WriteFile writes a list of records to the given file descriptor, as an
ARROW file.
+func WriteFileCompressed(t *testing.T, f *os.File, mem memory.Allocator,
schema *arrow.Schema, recs []array.Record, codec flatbuf.CompressionType) {
+ t.Helper()
+
+ opts := []ipc.Option{ipc.WithSchema(schema), ipc.WithAllocator(mem)}
+ switch codec {
+ case flatbuf.CompressionTypeLZ4_FRAME:
+ opts = append(opts, ipc.WithLZ4())
+ case flatbuf.CompressionTypeZSTD:
+ opts = append(opts, ipc.WithZstd())
+ }
Review comment:
Seems like errors in this method are returned via `t`, Should the same
be done there?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
