zanmato1984 commented on issue #46227: URL: https://github.com/apache/arrow/issues/46227#issuecomment-2840273227
Hi @jtanx , thanks for the reporting and the further digging. As you mentioned these seem quite like false positives as helgrind has known limitation in understanding modern C++ `atomic`s. > (although I'm not sure about [this case](https://github.com/apache/arrow/blob/4d566e60c5a12f047e1c0f36b9733a56513a7d43/cpp/src/arrow/acero/groupby_aggregate_node.cc#L377-L378)) This is also OK. The `OutputResult` here is only invoked single-threaded, see [1]. In other words, if ran multi-threaded, the condition `if (!segment.extends && segment.offset == 0)` never holds. So I'm closing this as a non-issue. Feel free to reopen if you find anything else. Thanks! [1] https://github.com/apache/arrow/blob/fc0862a25fa2d6aa17df14daa9ad37430d432425/cpp/src/arrow/acero/groupby_aggregate_node.cc#L128-L132 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
