amoeba commented on code in PR #46286:
URL: https://github.com/apache/arrow/pull/46286#discussion_r2070942506
##########
cpp/src/arrow/compute/kernels/vector_run_end_encode.cc:
##########
@@ -563,6 +568,11 @@ void RegisterVectorRunEndEncode(FunctionRegistry*
registry) {
for (const auto& ty : NumericTypes()) {
add_kernel(ty->id());
}
+
+ // TODO: Adding HALF_FLOAT to FloatingPointTypes() causes cascading failures
+ // so we specify it manually here. We should add it to FloatingPointTypes()
+ add_kernel(Type::HALF_FLOAT);
+
Review Comment:
If any reviewers want to take a look at adding HALF_FLOAT to
FloatingPointTypes I'd appreciate that. I made some initial progress fixing the
crashes adding HALF_FLOAT to FloatingPointTypes causes but got stuck on some
fairly obscure C++ templating errors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
