wgtmac commented on code in PR #46307:
URL: https://github.com/apache/arrow/pull/46307#discussion_r2072607008
##########
cpp/src/parquet/thrift_internal.h:
##########
@@ -106,6 +106,25 @@ static inline BoundaryOrder::type
FromThriftUnsafe(format::BoundaryOrder::type t
return static_cast<BoundaryOrder::type>(type);
}
+static inline GeometryLogicalType::EdgeInterpolationAlgorithm FromThriftUnsafe(
+ format::EdgeInterpolationAlgorithm::type type) {
+ switch (type) {
+ case format::EdgeInterpolationAlgorithm::SPHERICAL:
+ return GeometryLogicalType::EdgeInterpolationAlgorithm::SPHERICAL;
+ case format::EdgeInterpolationAlgorithm::VINCENTY:
+ return GeometryLogicalType::EdgeInterpolationAlgorithm::VINCENTY;
+ case format::EdgeInterpolationAlgorithm::THOMAS:
+ return GeometryLogicalType::EdgeInterpolationAlgorithm::THOMAS;
+ case format::EdgeInterpolationAlgorithm::ANDOYER:
+ return GeometryLogicalType::EdgeInterpolationAlgorithm::ANDOYER;
+ case format::EdgeInterpolationAlgorithm::KARNEY:
+ return GeometryLogicalType::EdgeInterpolationAlgorithm::KARNEY;
+ default:
+ ARROW_DCHECK(false) << "Cannot reach here";
Review Comment:
nit: use arrow::util::Unreachable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
