WillAyd commented on code in PR #46311:
URL: https://github.com/apache/arrow/pull/46311#discussion_r2072656699
##########
cpp/src/arrow/util/small_vector_test.cc:
##########
@@ -412,11 +412,6 @@ class TestSmallStaticVector : public ::testing::Test {
IntVectorType<N> moved_moved_ints = std::move(moved_ints);
ASSERT_EQ(moved_moved_ints.size(), 5);
EXPECT_THAT(moved_moved_ints, ElementsAre(4, 5, 6, 7, 8));
-
- // Move into itself
Review Comment:
The cpp standard makes it so that standard library types that are self
assigned like this exist in a valid but unspecified state, so I think testing
the contents of this after a self move does not rely upon standard behavior.
See also
https://stackoverflow.com/questions/68274999/is-it-allowed-to-self-move-an-object-in-c
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
