tustvold commented on PR #7468:
URL: https://github.com/apache/arrow-rs/pull/7468#issuecomment-2851736707
If I am not mistaken this will generate non-trivial code for all possible
values of dictionary key types and primitive key type, I don't think we can
really do this. Perhaps you could look at how the arithmetic kernels of other
selection kernels avoid this.
For reference on my computer before this change a clean build of
arrow-select and all dependents takes
```
$ time cargo build --release
Executed in 7.86 secs fish external
usr time 40.93 secs 0.00 micros 40.93 secs
sys time 1.55 secs 935.00 micros 1.54 secs
```
Whereas this PR
```
________________________________________________________
Executed in 11.58 secs fish external
usr time 57.66 secs 0.00 micros 57.66 secs
sys time 1.72 secs 923.00 micros 1.71 secs
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
