tustvold commented on code in PR #7479: URL: https://github.com/apache/arrow-rs/pull/7479#discussion_r2077891556
########## parquet/src/arrow/arrow_reader/mod.rs: ########## @@ -314,14 +314,19 @@ impl ArrowReaderOptions { } } - /// Provide a schema to use when reading the parquet file. If provided it - /// takes precedence over the schema inferred from the file or the schema defined - /// in the file's metadata. If the schema is not compatible with the file's - /// schema an error will be returned when constructing the builder. + /// Provide a schema to use when reading the Parquet file. /// - /// This option is only required if you want to cast columns to a different type. - /// For example, if you wanted to cast from an Int64 in the Parquet file to a Timestamp - /// in the Arrow schema. + /// If provided, this schema takes precedence over the schema inferred from Review Comment: This is not true, the schema in the parquet file must be authoritative. The arrow schema is merely a hint - see #1663 Edit: it may take precedence over the embedded arrow schema though, I don't recognise this particular codepath -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org