bkietz commented on code in PR #46017:
URL: https://github.com/apache/arrow/pull/46017#discussion_r2078205211
##########
cpp/src/parquet/encryption/encryption.cc:
##########
@@ -130,11 +123,11 @@ FileDecryptionProperties::Builder*
FileDecryptionProperties::Builder::aad_prefix
}
ColumnDecryptionProperties::Builder* ColumnDecryptionProperties::Builder::key(
- const std::string& key) {
+ encryption::SecureString key) {
if (key.empty()) return this;
- DCHECK(!key.empty());
- key_ = key;
+ DCHECK(key_.empty());
Review Comment:
I think you've corrected a bug; the intention with these setter methods
seems to be one-time setting
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
