kou commented on code in PR #46339:
URL: https://github.com/apache/arrow/pull/46339#discussion_r2078970166
##########
ci/scripts/cpp_build.sh:
##########
@@ -283,9 +283,10 @@ else
fi
if [ "${ARROW_USE_MESON:-OFF}" = "ON" ]; then
- time meson install
+ time meson compile -j ${ARROW_BUILD_PARALLEL:-$[${n_jobs} + 1]}
Review Comment:
Could you define `ARROW_BUILD_PARALLEL` out of this `if` to avoid the
default value duplication?
##########
dev/release/verify-release-candidate.sh:
##########
@@ -591,7 +591,7 @@ test_and_install_cpp() {
-DPARQUET_REQUIRE_ENCRYPTION=ON \
${ARROW_CMAKE_OPTIONS:-} \
${ARROW_SOURCE_DIR}/cpp
- export CMAKE_BUILD_PARALLEL_LEVEL=${CMAKE_BUILD_PARALLEL_LEVEL:-${NPROC}}
+ export CMAKE_BUILD_PARALLEL_LEVEL=${ARROW_BUILD_PARALLEL:-${NPROC}}
Review Comment:
Hmm. I think that we don't need this because we always use CMake in this
script.
If we want this, could you use use `ARROW_BUILD_PARALLEL` only if
`CMAKE_BUILD_PARALLEL` isn't defined?
##########
ci/scripts/cpp_build.sh:
##########
@@ -283,9 +283,10 @@ else
fi
if [ "${ARROW_USE_MESON:-OFF}" = "ON" ]; then
- time meson install
+ time meson compile -j ${ARROW_BUILD_PARALLEL:-$[${n_jobs} + 1]}
+ meson install
else
- export CMAKE_BUILD_PARALLEL_LEVEL=${CMAKE_BUILD_PARALLEL_LEVEL:-$[${n_jobs}
+ 1]}
+ export CMAKE_BUILD_PARALLEL_LEVEL=${ARROW_BUILD_PARALLEL:-$[${n_jobs} + 1]}
Review Comment:
Could you use `ARROW_BUILD_PARALLEL` only if `CMAKE_BUILD_PARALLEL_LEVEL`?
(If both of `CMAKE_BUILD_PARALLEL_LEVEL` and `ARROW_BUILD_PARALLEL`,
`CMAKE_BUILD_PARALLEL_LEVEL` should be used.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
