Xuanwo commented on code in PR #7377:
URL: https://github.com/apache/arrow-rs/pull/7377#discussion_r2081348878
##########
arrow-flight/Cargo.toml:
##########
@@ -73,6 +74,7 @@ http = "1.1.0"
http-body = "1.0.0"
hyper-util = "0.1"
pin-project-lite = "0.2"
+rustls = { version = "0.23", default-features = false, features = ["ring"] }
Review Comment:
We should enable it using `tonic = { .., features = ["transport", "codegen",
"prost", "tls-ring"]}` instead of relying directly on rustls.
Tricks happened at
https://docs.rs/tonic/latest/src/tonic/transport/channel/service/tls.rs.html#48-57
```rust
#[allow(unreachable_patterns)]
let builder = match crypto::CryptoProvider::get_default() {
Some(provider) => with_provider(provider.clone()),
#[cfg(feature = "tls-ring")]
None => with_provider(Arc::new(crypto::ring::default_provider())),
#[cfg(feature = "tls-aws-lc")]
None => with_provider(Arc::new(crypto::aws_lc_rs::default_provider())),
// somehow tls is enabled, but neither of the crypto features are
enabled.
_ => ClientConfig::builder(),
};
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
