hiroyuki-sato commented on PR #46381:
URL: https://github.com/apache/arrow/pull/46381#issuecomment-2868272838
@kou Thanks! I applied all of suggested changes.
I have two concerns.
* Compiler warning.
* Test failed.
Do we need to copy values?
```
../c_glib/arrow-glib/basic-data-type.cpp:2367:10: warning: address of stack
memory associated with local variable 'arrow_shape' returned
[-Wreturn-stack-address]
2367 | return arrow_shape.data();
| ^~~~~~~~~~~
1 warning generated.
```
```
============================================================================================================================================================================
Failure: test_shape_size(TestFixedShapeTensorDataType)
arrow/arrow/c_glib/test/test-fixed-shape-tensor-data-type.rb:36:in
'TestFixedShapeTensorDataType#test_shape_size'
33: end
34:
35: def test_shape_size
=> 36: assert_equal([3, 4], @data_type.shape)
37: end
38:
39: def test_to_s
<[3, 4]> expected but was
<[134527526204240, 2043]>
diff:
? [134527526204240, 2043]
============================================================================================================================================================================
Finished in 0.015831 seconds.
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------
8 tests, 10 assertions, 1 failures, 0 errors, 0 pendings, 0 omissions, 0
notifications
87.5% passed
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------
505.34 tests/s, 631.67 assertions/s
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
