kou commented on code in PR #46385:
URL: https://github.com/apache/arrow/pull/46385#discussion_r2083522484
##########
cpp/src/arrow/array/statistics.h:
##########
@@ -131,7 +137,9 @@ struct ARROW_EXPORT ArrayStatistics {
bool Equals(const ArrayStatistics& other) const {
return null_count == other.null_count && distinct_count ==
other.distinct_count &&
min == other.min && is_min_exact == other.is_min_exact && max ==
other.max &&
- is_max_exact == other.is_max_exact;
+ is_max_exact == other.is_max_exact &&
+ average_byte_width == other.average_byte_width &&
Review Comment:
1. Ah, I didn't notice it. Yes.
2. Yes.
3. (I think) No. I think `arrow::Array::Equals()` should check only data.
For example, metadata in its data type isn't used. But we may want to discuss
this in a separated issue.
4. Yes or no. Let's discuss it as a separated issue. I think that adding
`floating_approximate` to `EqualOptions` and using only `Equals` is better but
others may think differ.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
