raulcd commented on code in PR #45629:
URL: https://github.com/apache/arrow/pull/45629#discussion_r2084360250
##########
dev/archery/archery/crossbow/core.py:
##########
@@ -505,29 +505,27 @@ def github_upload_asset_requests(self, release, path,
name, mime,
result = release.upload_asset(name=name, asset=fp,
content_type=mime)
except github3.exceptions.ResponseError as e:
- logger.error('Attempt {} has failed with message: {}.'
- .format(i + 1, str(e)))
- logger.error('Error message {}'.format(e.msg))
- logger.error('List of errors provided by GitHub:')
+ logger.error(f"Attempt {i + 1} has failed with message:
{str(e)}.")
+ logger.error(f"Error message {e.msg}")
+ logger.error("List of errors provided by GitHub:")
for err in e.errors:
- logger.error(' - {}'.format(err))
+ logger.error(f" - {err}")
if e.code == 422:
# 422 Validation Failed, probably raised because
# ReleaseAsset already exists, so try to remove it before
# reattempting the asset upload
for asset in release.assets():
if asset.name == name:
- logger.info('Release asset {} already exists, '
- 'removing it...'.format(name))
+ logger.info(f"Release asset {name} already exists,
"
+ "removing it...")
asset.delete()
- logger.info('Asset {} removed.'.format(name))
+ logger.info(f"Asset {name} removed.")
break
except github3.exceptions.ConnectionError as e:
- logger.error('Attempt {} has failed with message: {}.'
- .format(i + 1, str(e)))
+ logger.error(f"Attempt {i + 1} has failed with message:
{str(e)}.")
Review Comment:
```suggestion
logger.error(f"Attempt {i + 1} has failed with message:
{e}.")
```
##########
dev/archery/archery/crossbow/core.py:
##########
@@ -505,29 +505,27 @@ def github_upload_asset_requests(self, release, path,
name, mime,
result = release.upload_asset(name=name, asset=fp,
content_type=mime)
except github3.exceptions.ResponseError as e:
- logger.error('Attempt {} has failed with message: {}.'
- .format(i + 1, str(e)))
- logger.error('Error message {}'.format(e.msg))
- logger.error('List of errors provided by GitHub:')
+ logger.error(f"Attempt {i + 1} has failed with message:
{str(e)}.")
Review Comment:
```suggestion
logger.error(f"Attempt {i + 1} has failed with message:
{e}.")
```
##########
dev/archery/archery/crossbow/core.py:
##########
@@ -1357,9 +1351,9 @@ def validate(self):
Task(task_name, **task)
except Exception as e:
raise CrossbowError(
- 'Unable to construct a task object from the '
- 'definition of task `{}`. The original error message '
- 'is: `{}`'.format(task_name, str(e))
+ "Unable to construct a task object from the "
+ f"definition of task `{task_name}`. The original error "
+ f"message is: `{str(e)}`"
Review Comment:
```suggestion
f"message is: `{e}`"
```
##########
python/pyarrow/tests/parquet/test_dataset.py:
##########
@@ -749,7 +749,7 @@ def test_dataset_memory_map(tempdir):
dirpath.mkdir()
df = _test_dataframe(10, seed=0)
- path = dirpath / '{}.parquet'.format(0)
+ path = dirpath / f'{0}.parquet'
Review Comment:
```suggestion
path = dirpath / '0.parquet'
```
##########
dev/archery/archery/crossbow/core.py:
##########
@@ -943,9 +941,8 @@ def render_files(self, searchpath, params=None):
params=params)
except jinja2.TemplateError as e:
raise RuntimeError(
- 'Failed to render template `{}` with {}: {}'.format(
- self.template, e.__class__.__name__, str(e)
- )
+ f"Failed to render template `{self.template}` with "
+ f"{e.__class__.__name__}: {str(e)}"
Review Comment:
```suggestion
f"{e.__class__.__name__}: {e}"
```
##########
python/pyarrow/tests/parquet/test_dataset.py:
##########
@@ -784,7 +784,7 @@ def test_dataset_enable_pre_buffer(tempdir):
dirpath.mkdir()
df = _test_dataframe(10, seed=0)
- path = dirpath / '{}.parquet'.format(0)
+ path = dirpath / f'{0}.parquet'
Review Comment:
```suggestion
path = dirpath / '0.parquet'
```
##########
python/pyarrow/tests/parquet/test_dataset.py:
##########
@@ -764,7 +764,7 @@ def test_dataset_enable_buffered_stream(tempdir):
dirpath.mkdir()
df = _test_dataframe(10, seed=0)
- path = dirpath / '{}.parquet'.format(0)
+ path = dirpath / f'{0}.parquet'
Review Comment:
```suggestion
path = dirpath / '0.parquet'
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
