kou commented on code in PR #40939: URL: https://github.com/apache/arrow/pull/40939#discussion_r2085806374
########## dev/release/rat_exclude_files.txt: ########## @@ -18,6 +18,8 @@ cpp/src/arrow/util/random.h cpp/src/arrow/status.cc cpp/src/arrow/status.h cpp/src/arrow/vendored/* +cpp/src/arrow/flight/sql/odbc/odbcabstraction/whereami.cc +cpp/src/arrow/flight/sql/odbc/odbcabstraction/whereami.h cpp/build-support/asan_symbolize.py Review Comment: 1. Yes but could you move to `cpp/src/arrow/vendored/whereami/` instead? 2. It's not required but it's better for easy to maintain. Could you also update `LICENSE.txt` too? See also: https://infra.apache.org/licensing-howto.html#permissive-deps -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
