kszucs commented on code in PR #45360:
URL: https://github.com/apache/arrow/pull/45360#discussion_r2086657214
##########
cpp/src/parquet/chunker_internal_test.cc:
##########
@@ -0,0 +1,1689 @@
+// Licensed to the Apache Software Foundation (ASF) under one
Review Comment:
I have a test suite configuration mostly for completeness:
```cpp
INSTANTIATE_TEST_SUITE_P(
FixedSizedTypes, TestCDCSingleRowGroup,
testing::Values(
// Boolean
CaseConfig{::arrow::boolean(), false},
// Numeric
CaseConfig{::arrow::uint8(), false}, CaseConfig{::arrow::uint16(),
false},
CaseConfig{::arrow::uint32(), false}, CaseConfig{::arrow::uint64(),
true},
CaseConfig{::arrow::int8(), false}, CaseConfig{::arrow::int16(),
false},
CaseConfig{::arrow::int32(), false}, CaseConfig{::arrow::int64(),
true},
CaseConfig{::arrow::float16(), false},
CaseConfig{::arrow::float32(), false},
CaseConfig{::arrow::float64(), true},
CaseConfig{::arrow::decimal128(18, 6), false},
CaseConfig{::arrow::decimal256(40, 6), false},
// Binary-like
CaseConfig{::arrow::utf8(), false}, CaseConfig{::arrow::binary(),
true},
CaseConfig{::arrow::fixed_size_binary(16), true},
// Temporal
CaseConfig{::arrow::date32(), false},
CaseConfig{::arrow::time32(::arrow::TimeUnit::MILLI), true},
CaseConfig{::arrow::time64(::arrow::TimeUnit::NANO), false},
CaseConfig{::arrow::timestamp(::arrow::TimeUnit::NANO), true},
CaseConfig{::arrow::duration(::arrow::TimeUnit::NANO), false},
// Nested types
CaseConfig{::arrow::list(::arrow::int32()), false},
CaseConfig{::arrow::list(::arrow::int32()), true},
CaseConfig{::arrow::list(::arrow::utf8()), true},
CaseConfig{::arrow::struct_({::arrow::field("f0",
::arrow::int32())}), false},
CaseConfig{::arrow::struct_({::arrow::field("f0",
::arrow::float64())}), true},
CaseConfig{
::arrow::list(::arrow::struct_({::arrow::field("f0",
::arrow::int32())})),
false},
// Extension type
CaseConfig{::arrow::extension::json(), true},
// Use ParquetDataPageVersion::V2
CaseConfig{::arrow::large_binary(), false,
ParquetDataPageVersion::V2},
CaseConfig{::arrow::list(::arrow::utf8()), true,
ParquetDataPageVersion::V2}));
```
I can split this into two sets of cases, by default a small set would be
exercised but could be explicitly enabled by a gtest flag. Opinions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
