mapleFU commented on code in PR #46372: URL: https://github.com/apache/arrow/pull/46372#discussion_r2093545719
########## cpp/src/parquet/variant.h: ########## @@ -0,0 +1,261 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#pragma once + +#include <cstdint> +#include <optional> +#include <string_view> +#include <vector> + +#include <arrow/util/decimal.h> +#include <arrow/util/small_vector.h> + +namespace parquet::variant { + +// TODO(mwish): Should I use parquet::ByteArray rather than +// std::string_view? + +enum class VariantBasicType { + /// One of the primitive types + Primitive = 0, Review Comment: Actually this codebase doesn't have this style? Like: ```c++ enum class ParquetDataPageVersion { V1, V2 }; /// Controls the level of size statistics that are written to the file. enum class SizeStatisticsLevel : uint8_t { // No size statistics are written. None = 0, // Only column chunk size statistics are written. ColumnChunk, // Both size statistics in the column chunk and page index are written. PageAndColumnChunk }; ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
