kou commented on code in PR #17: URL: https://github.com/apache/arrow-js/pull/17#discussion_r2096624475
########## docker-compose.yml: ########## Review Comment: Could you use recommended `compose.yaml` (not `.yml`) file name for Docker Compose v2? See also: https://docs.docker.com/compose/gettingstarted/#step-2-define-services-in-a-compose-file ########## docker-compose.yml: ########## @@ -0,0 +1,54 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +# Usage +# ----- +# +# The docker compose file is parametrized using environment variables, the +# defaults are set in .env file. +# +# Example: +# $ ARCH=amd64 docker compose build debian-js +# $ ARCH=amd64 docker compose run debian-js + +volumes: + debian-ccache: + name: ${ARCH}-debian-${DEBIAN}-ccache Review Comment: We don't need to use `ccache`. We want to use `jest` instead: ```suggestion jest-cache: name: jest-cache ``` ########## docker-compose.yml: ########## @@ -0,0 +1,54 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +# Usage +# ----- +# +# The docker compose file is parametrized using environment variables, the +# defaults are set in .env file. +# +# Example: +# $ ARCH=amd64 docker compose build debian-js +# $ ARCH=amd64 docker compose run debian-js + +volumes: + debian-ccache: + name: ${ARCH}-debian-${DEBIAN}-ccache + +services: + debian-js: Review Comment: ```suggestion debian: ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
